----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117966/#review57942 -----------------------------------------------------------
I am using: ./sql_keywords.sh /tmp/sqlite-src-3080403.zip /tmp/mysql-5.6.17.tar.gz /tmp/postgresql-9.3.4.tar.gz Please try this case. Matching does not work because the code such as [[ ! $sqlArchive == sqlite*.zip ]] expects filename without a path. Better do not expect people to save the archives in source dir calligra/kexi/tools/sql_keywords/. kexi/tools/sql_keywords/sql_keywords.sh <https://git.reviewboard.kde.org/r/117966/#comment40337> to avoid confusion, order should be fixed in lines 17-19 (my mistake) kexi/tools/sql_keywords/sql_keywords.sh <https://git.reviewboard.kde.org/r/117966/#comment40338> Please prepend license from ./kexiutils/generate_transliteration_table.sh and usual copyright lines for Martin and you: Copyright (C) .... .... <...@....> - Jarosław Staniek On May 14, 2014, 7:45 p.m., Wojciech Kosowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117966/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 7:45 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > This patch contains changes for sql_keywords.sh script that generates source > files that contains keywords for specific database technology (kexisql, > sqlite, postrsql, mysql). > I did my best still I think functions getPostgreSQLKeywords and > getSQLiteKeywords can be done in a better (old mechanism did not work but I > think there can be better ways than what I came up with. > Every suggestions are welcome > TODO: > updating comments as some functions changed names/attributes > > > Diffs > ----- > > kexi/tools/sql_keywords/sql_keywords.sh 6bcc5de > > Diff: https://git.reviewboard.kde.org/r/117966/diff/ > > > Testing > ------- > > 4 files that contained keywords are generated and they do contain them > > > Thanks, > > Wojciech Kosowicz > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
