----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118044/#review57526 -----------------------------------------------------------
Thanks for the code. Results below. kexi/migration/odb/myDbTwo.java <https://git.reviewboard.kde.org/r/118044/#comment40030> All object references are null by default, no need to add '= null' everywhere in the code. See http://www.javapractices.com/topic/TopicAction.do?Id=14 kexi/migration/odb/myDbTwo.java <https://git.reviewboard.kde.org/r/118044/#comment40031> How about using program's 0th argument from "String[] args" instead of hardcoded path? kexi/migration/odb/myDbTwo.java <https://git.reviewboard.kde.org/r/118044/#comment40032> missing indentation kexi/migration/odb/myDbTwo.java <https://git.reviewboard.kde.org/r/118044/#comment40033> missing indentation - Jarosław Staniek On May 7, 2014, 8:48 p.m., harshita mistry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118044/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 8:48 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > A java program that formats odb files and reads data from hsqldb using hsqldb > jdbc driver. > > > Diffs > ----- > > kexi/migration/odb/myDbTwo.java PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118044/diff/ > > > Testing > ------- > > > Thanks, > > harshita mistry > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
