Hi, I am forwarding this RR to the calligra mailinglist, because svn.reviewboard.kde.org does not have a reviewer group calligra.
Thanks. ---------- Weitergeleitete Nachricht ---------- Betreff: Review Request 7110: Install only one translated autocorrect xm from l10n-kde4/[lang]/data Datum: Dienstag, 6. Mai 2014, 11:43:37 Von: Burkhard Lück <lu...@hube-lueck.de> An: Burkhard Lück <lu...@hube-lueck.de>, Localization and Translation (l10n) <kde-i18n-...@kde.org>, KDE PIM <kde-...@kde.org> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://svn.reviewboard.kde.org/r/7110/ ----------------------------------------------------------- Review request for KDE PIM and Localization and Translation (l10n). Repository: kde Description ------- trunk/l10n-kde4/[lang]/data + branches/stable/[lang]/data both have two identical translated autocorrect xml files with different names in two different subdirs and different install path: 1) kdelibs/autocorrect/de_DE.xml with install( FILES de_DE.xml DESTINATION ${DATA_INSTALL_DIR}/autocorrect ) and 2) calligra/autocorrect/de.xml with install( FILES de.xml DESTINATION ${DATA_INSTALL_DIR}/calligra/autocorrect ) As far as I understand the code in calligra/plugins/textediting/autocorrection/Autocorrect.cpp and kdepim/pimcommon/autocorrection/autocorrection.cpp calligra + kdepim would find the autocorrrect file de.xml installed to ${DATA_INSTALL_DIR}/autocorrect ), therefore the duplicated autocorrect file should be removed Diffs ----- trunk/l10n-kde4/de/data/calligra/autocorrect/CMakeLists.txt 1386314 trunk/l10n-kde4/de/data/calligra/autocorrect/de.xml 1386314 trunk/l10n-kde4/de/data/kdelibs/autocorrect/CMakeLists.txt 1386314 trunk/l10n-kde4/de/data/kdelibs/autocorrect/de_DE.xml 1386314 Diff: https://svn.reviewboard.kde.org/r/7110/diff/ Testing ------- Thanks, Burkhard Lück ------------------------------------------------------------- -- Burkhard Lück _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
