----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117937/#review57116 -----------------------------------------------------------
This review has been submitted with commit f6ca90eb379e651c0f1689294b01e5e3bb0c1b3f by Friedrich W. H. Kossebau to branch master. - Commit Hook On May 1, 2014, 10:36 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117937/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 10:36 p.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Repository: calligra > > > Description > ------- > > The Ok & Cancel buttons in the Krita filter dialog are not following the > standards, also will not adapt to different Cancel/Ok order on other > platforms (e.g. Gnome OS). Also are some margins hardcoded to certain random > pixel sizes, which is a problem on HiDPI screens and with styles where those > margins do not match the built-in ones. > > These two patches remove some hard-coded margins, use a QButtonBox for the Ok > and Cancel buttons and also some ";" to labels where they are missing. > > > Diffs > ----- > > krita/plugins/filters/blur/wdg_motion_blur.ui 5377ccf > krita/plugins/filters/blur/wdg_lens_blur.ui e7daea4 > krita/plugins/filters/blur/wdg_gaussian_blur.ui 728f608 > krita/plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp 85f476c > krita/ui/dialogs/kis_dlg_filter.cpp 4fd86ca > krita/ui/forms/wdgfilterdialog.ui 7a1e3c6 > krita/ui/forms/wdgfilterselector.ui c9d87c7 > > Diff: https://git.reviewboard.kde.org/r/117937/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > After, by example of levels filter > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/01/cbb4ea9c-90a8-4b0d-90e0-febdca546f98__filterdialogafter.png > Before, by example of levels filter > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/01/9dd88e38-8a3f-4ab5-aced-ecad20d887db__filterdialogbefore.png > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
