> On March 13, 2014, 10:32 a.m., Cyrille Berger Skott wrote: > > sheets/functions/math.cpp, line 1233 > > <https://git.reviewboard.kde.org/r/116611/diff/1/?file=252212#file252212line1233> > > > > This line is wrong, it should be eMatrixInverse = eMatrix.inverse(); > > > > and line 1231 with the FullPivLU can be removed. > > Maximiliano Curia wrote: > I think it needs to be replaced with: > eMatrixInverse = lu.inverse(); > > As eMatrix doesn't provide a isInversible check, and even if it does it > would be quite inefficient to internally produce the lu decomposition twice. >
Do you think it would be possible to have a final patch today, so we can have it correct and merged in time for the 2.8.1 tagging tomorrow? - Boudewijn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116611/#review52879 ----------------------------------------------------------- On March 5, 2014, 12:36 p.m., Maximiliano Curia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116611/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 12:36 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > Hi, > > In Debian eigen2 was removed from the archive, so, this is the patch we are > using to support eigen3. The pathch was originaly developed by Anton Gladky, > and later modified by the debian calligra maintainers. > > Please consider adding it as part of the official calligra. > > Happy hacking, > > > Diffs > ----- > > krita/plugins/tools/selectiontools/kis_tool_select_magnetic.h > d69c6b82845b00bc6e540d5daccafcc9850f4dc5 > krita/plugins/tools/selectiontools/kis_tool_select_brush.cc > 08cd4efdc071145485abd511885546a63c44390e > krita/plugins/paintops/libbrush/CMakeLists.txt > ac9cd72146eebefe58d20896b63c7d221460d288 > > krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.cpp > f2889b866c3d733f8fbc3ac5c93ba94061099b2c > > krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_ring.cpp > 5f88701aea3eddcf4d3deb5059f91d12cb22fd71 > krita/image/tests/kis_paint_information_test.cpp > 188103c29add9bb706134ff75ae9e260af5b0de0 > krita/image/tests/kis_convolution_painter_test.cpp > d6562dd3aef886d4173ee4f2c18692fc0ae13f82 > krita/image/kis_perspective_math.cpp > 74566e205244e92627cf84adc1360204028ddeba > krita/CMakeLists.txt b81e9f41c78291b284e04a613b00ba4d1c8a5191 > cmake/modules/FindEigen3.cmake PRE-CREATION > CMakeLists.txt f3a193c20c83fe8df737be838d23d9f5247c997c > sheets/CMakeLists.txt 04f213f72a06c32f790c86091d97e19900a70a91 > sheets/functions/CMakeLists.txt ba20613be6ca0c8516f19a6bcb9da861370b098b > sheets/functions/math.cpp 6b475f5dbc4bac22b2f6930ec25e08b302e6abe2 > sheets/tests/CMakeLists.txt 0d1d37c09d0415c10133cc5c27dad9b3e9693eb1 > > Diff: https://git.reviewboard.kde.org/r/116611/diff/ > > > Testing > ------- > > > Thanks, > > Maximiliano Curia > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
