-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111413/
-----------------------------------------------------------
(Updated Nov. 24, 2013, 6:13 p.m.)
Review request for Calligra.
Changes
-------
Split the patch for kdgantt and fixed the remaining issues
Bugs: 321290
http://bugs.kde.org/show_bug.cgi?id=321290
Repository: calligra
Description
-------
Plan uses week numbering extensively. The default week numbering in KDE is ISO
Week, which uses Monday as first day of the week, regardless of other locale
settings.
To make it consistent through the application, if week numbering format is ISO
Week, set the first day of the week to Monday, and display it accordingly in
charts and graphs.
Without this patch, the week could be set to start on Sunday, and week would be
shown on graphs as ranging from Sunday to Saturday, but the week number of
working days would be off by one.
Example:
- Week numbering: ISO Week
- First day of week: Sunday
Without patch:
- Week displayed: 2013-07-07 to 2013-07-13
- Week number shown on charts: 27
- Expected week number: 28 (Week 27 ends on Sunday 2013-07-07)
With patch:
- Week displayed: 2013-07-08 to 2013-07-14
- Week number shown on charts: 28
Additionally, there were a few calls to QDate::week() to get the week number,
instead of using KGlobalCalendar.
Diffs (updated)
-----
plan/libs/models/kcalendar/kdatetable.cpp b389345
plan/libs/models/kptaccountsmodel.cpp 71c3100
plan/libs/ui/kptganttview.cpp 81073a3
Diff: http://git.reviewboard.kde.org/r/111413/diff/
Testing
-------
Tested on a live file. It displays calendars and gantt charts correctly.
Thanks,
Alvaro Soliverez
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
