----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112080/ -----------------------------------------------------------
Review request for Calligra. Description ------- A rather chunky patch again, I'm afraid. KoResourceItemChooser has been stripped of the tagging code, along with the GUI bits for it. KoResourceTaggingInterface now contains the logic (assignment, renaming, etc), it also does the context menu for the resources themselves (maybe that should go into its own bit, too). KoTagFilterWidget is the GUI bit for all filtering/searching operations. KoTagChooserWidget is the GUI bit for choosing tags along with a tool button for modifying them (addition, removal, renaming, undeletion) I've also updated my email address as well as some whitespace errors which got fixed along the way. ------------------------------------------ This is my first attempt at creating custom widgets. That is most likely the reason for several issues that the code has. 1.) http://s18.postimg.org/9bgox9yvb/2013_08_08_171912_3200x1080_scrot.png The layout breaks for KoResourceItemChooser instances where tagging and filter bar are shown. When they are hidden (like predefined brush settings, or favorite brush palette manager), the gaps don't occur. 2.) I have no idea if the widget/GUI code I have written is up to style/standards in general. (pimpl (which I was corrected on before, but I think it makes sense this time), using privacy and friends, etc) 3.) I don't know if I split the components sensibly. Any pointers on any of that will be highly appreciated and incorporated as promptly as I am able to ^^ Diffs ----- krita/ui/kis_palette_manager.cpp 53b9c58 krita/ui/widgets/kis_preset_chooser.h 92d1501 krita/ui/widgets/kis_preset_chooser.cpp 4da9ed3 krita/ui/widgets/kis_workspace_chooser.cpp 0100372 libs/widgets/CMakeLists.txt a1b9344 libs/widgets/KoResourceFiltering.h ca5a360 libs/widgets/KoResourceFiltering.cpp 4a3976e libs/widgets/KoResourceItemChooser.h b5e0022 libs/widgets/KoResourceItemChooser.cpp 2f9e71f libs/widgets/KoResourceItemChooserContextMenu.h fb5bfbb libs/widgets/KoResourceItemChooserContextMenu.cpp bfeb907 libs/widgets/KoResourceModel.h 783de22 libs/widgets/KoResourceModel.cpp 636dd44 libs/widgets/KoResourceServer.h a56e9b4 libs/widgets/KoResourceServerAdapter.h 7d63504 libs/widgets/KoResourceTaggingInterface.h PRE-CREATION libs/widgets/KoResourceTaggingInterface.cpp PRE-CREATION libs/widgets/KoTagChooserWidget.h PRE-CREATION libs/widgets/KoTagChooserWidget.cpp PRE-CREATION libs/widgets/KoTagFilterWidget.h PRE-CREATION libs/widgets/KoTagFilterWidget.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112080/diff/ Testing ------- Manual, thorough testing, Krita only. Could not detect regressions in actual functionality. Thanks, Sascha Suelzer
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
