-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111657/
-----------------------------------------------------------
(Updated July 24, 2013, 11:40 p.m.)
Review request for Calligra.
Changes
-------
Made changes according to review
- Added new enum
- Uses that enum in Task::addUsedEffort
- Added the enum to case in Node::changed() to refresh performance caches
Description
-------
* When effort is added to a task, use the Node::CompletionActualEffort property
to have the performance cache should be refreshed when it hits Node::changed()
method.
This solves bug 322735, where the project performance chart is not refreshed.
This is because there is a cache that does not get refreshed unless the
changed() method is called with the correct property.
* Instead of traversing all nodes looking for the one without parent, request
the project for that node using projectNode(). Just a small optimization. The
one node without parent is the project node, which can be easily requested,
instead of making a O(n2) loop.
This addresses bug 322735.
http://bugs.kde.org/show_bug.cgi?id=322735
Diffs (updated)
-----
plan/libs/kernel/kptnode.h f711fa4
plan/libs/kernel/kptnode.cpp ee5039a
plan/libs/kernel/kpttask.cpp da48be0
Diff: http://git.reviewboard.kde.org/r/111657/diff/
Testing
-------
Tested manually. The performance chart is refreshed correctly and there were no
apparent performance drops or other side-effects.
Thanks,
Alvaro Soliverez
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
