----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111305/ -----------------------------------------------------------
Review request for Calligra, C. Boemann and Inge Wallin. Description ------- The installed libs "libmsooxml", "libodfreader", "libvectorimage", "libtextlayout" ideally also get a prefix. Attached patch does that. It does not touch "pigment", "flake", "basicflakes", as these have unique enough names IMHO, so no clash can be expected. Also does not touch the internal static libs which do not (yet?) get installed: mso, writerperfect. libRtfReader would also be a candidate, but it is unclear to me whether we have the original clone of that lib in our repo, and the other one (on sf.net) should be removed. So ignoring that one here. Open questions for me: * "kundo2", "kformdesigner", "kformula" just use a k as prefix, so might clash with libs sometimes in kdelibs/kdeplatform? So better instead prefix with ko, not just k? * also rename the subdirs in the repo? libs/ currently has a mix also without this patch: "main", "odf" and "rdf" are without ko, the other have the prefix in the subdir name. What would you think about a follow-up patch which adds consistency there? Will write an email to the mailinglist about that to query what people think, after this patch has been handled (discarded/committed). Diffs ----- CMakeLists.txt 53fa5bd filters/karbon/wmf/CMakeLists.txt bc278f1 filters/libmsooxml/CMakeLists.txt a9827cb filters/libodfreader/CMakeLists.txt 71571f8 filters/sheets/excel/export/CMakeLists.txt efd8e1a filters/sheets/excel/import/CMakeLists.txt 06c6f9f filters/sheets/xlsx/CMakeLists.txt 1a3ca07 filters/stage/pptx/CMakeLists.txt ea87a0e filters/words/ascii/CMakeLists.txt e9846f9 filters/words/docx/import/CMakeLists.txt 32472dc filters/words/epub/CMakeLists.txt 8954e75 filters/words/msword-odf/CMakeLists.txt 7479b5e libs/kopageapp/CMakeLists.txt 35db53f libs/main/CMakeLists.txt d74851b libs/textlayout/CMakeLists.txt 3d9edfe libs/textlayout/tests/CMakeLists.txt 71dc053 libs/vectorimage/CMakeLists.txt 2c25ce8 plugins/chartshape/CMakeLists.txt 1a7fbe3 plugins/commentshape/CMakeLists.txt bf90d37 plugins/textediting/spellcheck/CMakeLists.txt 0dec50e plugins/textshape/CMakeLists.txt 322f93e plugins/variables/CMakeLists.txt 6e47086 plugins/vectorshape/CMakeLists.txt 739b9ba stage/part/CMakeLists.txt 6eaf356 stage/plugins/variable/CMakeLists.txt 0893a76 words/part/CMakeLists.txt 437f443 Diff: http://git.reviewboard.kde.org/r/111305/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
