----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110696/#review33300 -----------------------------------------------------------
This review has been submitted with commit a926913cb51ad195b53b3fe3e2ef8655a7c27ad7 by Elvis Stansvik to branch master. - Commit Hook On May 28, 2013, 2:42 p.m., Elvis Stansvik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110696/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 2:42 p.m.) > > > Review request for Calligra. > > > Description > ------- > > In KoStyleManager::add(KoCharacterStyle *style) and > KoStyleManager::add(KoParagraphStyle *style), the d->s_stylesNumber static > variable used for assigning style IDs was wrongly used after it had been > incremented. I fixed this and also moved the incrementing to a separate > statement at the end of the block in the other functions, to minimize the > risk of it happening again. > > > Diffs > ----- > > libs/kotext/styles/KoStyleManager.cpp 32cbbcb > > Diff: http://git.reviewboard.kde.org/r/110696/diff/ > > > Testing > ------- > > > Thanks, > > Elvis Stansvik > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
