----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110581/#review32915 -----------------------------------------------------------
Ship it! Looks good. I have only one issue, otherwise it's fine to commit. ...and backport. CMakeLists.txt <http://git.reviewboard.kde.org/r/110581/#comment24408> This is clearly overkill. Most other libraries in calligra are just referred to by their names. Just look at the uses below. - Inge Wallin On May 21, 2013, 6:31 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110581/ > ----------------------------------------------------------- > > (Updated May 21, 2013, 6:31 p.m.) > > > Review request for Calligra. > > > Description > ------- > > There might be some other people out there that use libkdchart... so to > prevent any naming clashes we better prefix our copy. > > Okay to backport to 2.7? > > > Diffs > ----- > > 3rdparty/kdchart/src/CMakeLists.txt 0c62a5d > CMakeLists.txt 8b84dca > kexi/plugins/reports/CMakeLists.txt 14e0ff9 > plan/libs/models/CMakeLists.txt f168557 > plan/libs/ui/CMakeLists.txt f813a10 > plugins/chartshape/CMakeLists.txt c853ec0 > plugins/reporting/chart/CMakeLists.txt 92bf3de > > Diff: http://git.reviewboard.kde.org/r/110581/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
