----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110080/#review31291 -----------------------------------------------------------
kexi/plugins/reports/kexireportview.cpp <http://git.reviewboard.kde.org/r/110080/#comment23306> "What's this" should be: "Goes to previous page", the same for lines below kexi/widget/utils/kexirecordnavigator.cpp <http://git.reviewboard.kde.org/r/110080/#comment23299> Can we split to setButtonToolTipText() and setButtonWhatsThis()? Tooltips tend to be different texts than whatsthis-text. kexi/widget/utils/kexirecordnavigator.cpp <http://git.reviewboard.kde.org/r/110080/#comment23300> Could we please stay with the switch() as more clear code? kexi/widget/utils/kexirecordnavigator.cpp <http://git.reviewboard.kde.org/r/110080/#comment23305> IMHO It's rare approach to set tooltips for labels (too intrusive). I propose to have setNumberFieldWhatsThis() and setting 'whats this' text only. - Jarosław Staniek On April 18, 2013, 9:59 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110080/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 9:59 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Description > ------- > > Ideally the record/page/... navigator tools of Kexi, Stage, Plan and (?) > would be merged into a single class, for consistency and code sharing. > > Until then, let's at least have the page navigator tool in the report view of > Kexi show sane tooltips, and not talk about records when there are pages :) > > > Diffs > ----- > > kexi/widget/utils/kexirecordnavigator.cpp b1e2384 > kexi/widget/utils/kexirecordnavigator.h b73fe4f > kexi/plugins/reports/kexireportview.cpp c215e8a > > Diff: http://git.reviewboard.kde.org/r/110080/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
