----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109926/#review31175 -----------------------------------------------------------
Ship it! Looks fine. There are some small things but there is one issue that you need to fix: The on/off action for this feature should go into the View menu rather than the Settings menu. words/part/author/CAuView.cpp <http://git.reviewboard.kde.org/r/109926/#comment23186> This is fine for now but in the long run the on/off status should be saved just like the status of other UI settings. words/part/author/author.rc <http://git.reviewboard.kde.org/r/109926/#comment23187> This should go into the View menu, not the Settings. And I think that it would be better if it was called "Word Count" since this is what people seem to expect. Our full statistics seems to not be noticed because they are looking for "word count", at least that seems to be the case for comments I've seen as well as a magazine review. words/part/dockers/KWStatisticsWidget.h <http://git.reviewboard.kde.org/r/109926/#comment23188> we normally use the shortVersion type of names rather than short_version. - Inge Wallin On April 14, 2013, 10:30 p.m., Jérémy BOURDIOL wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109926/ > ----------------------------------------------------------- > > (Updated April 14, 2013, 10:30 p.m.) > > > Review request for Calligra. > > > Description > ------- > > For Author > Integration of some particular statistics in the status bar. > Creation of a "short version" of the KWStatisticsWidget of words/Author > > > Diffs > ----- > > words/part/author/CAuView.h 8c8f1cf > words/part/author/CAuView.cpp cef9be4 > words/part/author/author.rc b3b187c > words/part/dockers/KWStatisticsWidget.h 3e2fd39 > words/part/dockers/KWStatisticsWidget.cpp 142aeb8 > > Diff: http://git.reviewboard.kde.org/r/109926/diff/ > > > Testing > ------- > > Direct test, write a little text. > Code is the same as KWStatisticsWidget > > > File Attachments > ---------------- > > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/04/09/calliga_author_stats.png > > > Thanks, > > Jérémy BOURDIOL > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
