----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109907/ -----------------------------------------------------------
Review request for Calligra. Description ------- Currently kfiledialog and kofiledialog is widely used, this results in non-native file dialog on Mac/Windows/Gnome. However, qfiledialog static methods does not support modal sheet in Mac, so a KoModalFileDialog is created for window-modal file dialog, such as save as or import, while other file dialog such as open will use qfiledialog static methods. This is a very first version which blocks save as encrypted since encrypted odf has same suffix as normal odf while when using native dialog you have to use suffix to distinguish different format. My idea is to create another menu item "Save As Encrypted..." where encrypted odf will be saved. There are still many file dialogs not touched yet, and for places where kfilewidget is used, such as startup file open widget, kexi file widget, export to pdf widget, it is impossible to use native dialog. My idea is redesign those widget and split the configure part and file chooser part into two separate dialogs, then use native file dialogs. Diffs ----- krita/plugins/extensions/bigbrother/bigbrother.cc f59e55e libs/main/CMakeLists.txt d74851b libs/main/KoFileDialog.h da94281 libs/main/KoFileDialog.cpp c5a7fc2 libs/main/KoMainWindow.cpp a739cbb libs/main/KoModalFileDialog.h PRE-CREATION libs/main/KoModalFileDialog.cpp PRE-CREATION plan/workpackage/application.cpp 942d5a7 sheets/dialogs/CSVDialog.h 0763538 sheets/dialogs/CSVDialog.cpp 4d6a19d Diff: http://git.reviewboard.kde.org/r/109907/diff/ Testing ------- Works fine on OS X 10.8 File Attachments ---------------- save as dialog http://git.reviewboard.kde.org/media/uploaded/files/2013/04/08/Screen_Shot_2013-04-07_at_11.54.47_PM.png Thanks, Yue Liu
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
