----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109320/#review29884 -----------------------------------------------------------
This review has been submitted with commit 88026ee4e6c229e4358f0bb5ffb4a54cbd05fe4b by Inge Wallin to branch master. - Commit Hook On March 6, 2013, 8:11 p.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109320/ > ----------------------------------------------------------- > > (Updated March 6, 2013, 8:11 p.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Description > ------- > > This patch normalizes the SIGNAL and SLOT signatures in krita/ui. There were > >200 issues in all of krita so I limited this batch to krita/ui. This is > approximately half of the unnormalized signatures in all of krita so there > will be a batch 2 if this is ok'ed. > > As a side note, before this patch, I passed the 1000-issues-fixed mark. :) > > > Diffs > ----- > > krita/ui/canvas/kis_canvas2.cpp bb41065 > krita/ui/dialogs/kis_dlg_generator_layer.cpp a9a0de7 > krita/ui/flake/kis_dummies_facade_base.cpp 12ab999 > krita/ui/flake/kis_shape_controller.cpp 5b56b10 > krita/ui/kis_canvas_resource_provider.cpp fb317c6 > krita/ui/kis_control_frame.cpp 262e197 > krita/ui/kis_node_model.cpp 76e03d5 > krita/ui/kis_popup_palette.cpp 0deb1fb > krita/ui/kis_view2.cpp b864f90 > krita/ui/tests/modeltest.cpp 5d0b9de > krita/ui/widgets/kis_categorized_list_view.cpp d839c598 > krita/ui/widgets/kis_paintop_presets_chooser_popup.cpp d7f2984 > krita/ui/widgets/kis_paintop_presets_popup.cpp 18da08e > krita/ui/widgets/kis_scratch_pad.cpp 2aac338 > krita/ui/widgets/squeezedcombobox.cpp 36c4b9f > > Diff: http://git.reviewboard.kde.org/r/109320/diff/ > > > Testing > ------- > > Builds correctly but there should be some testing and manual inspection. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
