> On Feb. 28, 2013, 6:21 p.m., Boudewijn Rempt wrote: > > libs/basicflakes/tools/KoPencilTool.h, line 94 > > <http://git.reviewboard.kde.org/r/109123/diff/1/?file=115215#file115215line94> > > > > Yes, I am fine with this change -- though I wonder if it wouldn't be > > nicer to keep the actual variable private in the base class and create a > > protected getter/setter.
Yeah that would be better. So here is the updated patch. - Somsubhra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109123/#review28284 ----------------------------------------------------------- On March 1, 2013, 4:33 a.m., Somsubhra Bairi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109123/ > ----------------------------------------------------------- > > (Updated March 1, 2013, 4:33 a.m.) > > > Review request for Calligra and Boudewijn Rempt. > > > Description > ------- > > Set the freehand tool curve exactness default value to 1 > > > This addresses bug 313593. > http://bugs.kde.org/show_bug.cgi?id=313593 > > > Diffs > ----- > > krita/plugins/tools/defaulttools/kis_tool_pencil.cc aace615 > libs/basicflakes/tools/KoPencilTool.h 0d586c4 > libs/basicflakes/tools/KoPencilTool.cpp f6ac4c9 > > Diff: http://git.reviewboard.kde.org/r/109123/diff/ > > > Testing > ------- > > > Thanks, > > Somsubhra Bairi > >
_______________________________________________ calligra-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/calligra-devel
