----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107800/#review23684 -----------------------------------------------------------
filters/words/epub/EpubFile.cpp <http://git.reviewboard.kde.org/r/107800/#comment18115> Does the cover have to be the first itemref? If not, this loop is better integrated into the loop just below. filters/words/epub/exportepub2.cpp <http://git.reviewboard.kde.org/r/107800/#comment18118> Should be const QString & Also: It seems a bit dangerous to assume that the cover image is the only file in this directory. You should look explicitly for cover.* filters/words/epub/exportepub2.cpp <http://git.reviewboard.kde.org/r/107800/#comment18116> Extract filters/words/epub/exportepub2.cpp <http://git.reviewboard.kde.org/r/107800/#comment18117> Should add coverPath to the debug output too. filters/words/epub/exportepub2.cpp <http://git.reviewboard.kde.org/r/107800/#comment18119> I think "cover image" is enough... words/part/KWOdfWriter.cpp <http://git.reviewboard.kde.org/r/107800/#comment18120> I think coverImage would be a better name. Just 'cover' could mean a page or something else too. This review is super old but I'm publishing it to see if the error I got before was because of a faulty browser or because of a faulty reviewboard. - Inge Wallin On Dec. 21, 2012, 3:12 p.m., mojtaba shahi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107800/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2012, 3:12 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Add Book --> Insert Cover Image, to menu that lets user to select an image, > class will get it and at writing time > it (cover) will save at Authoer-Profile. In epub add an extra html file > include just an image (cover) as ebook cover. > > > Diffs > ----- > > filters/words/epub/EpubFile.cpp 4018d08 > filters/words/epub/exportepub2.h c1311aa > filters/words/epub/exportepub2.cpp 8c81e10 > words/part/CMakeLists.txt 3dca430 > words/part/KWDocument.h 9a57029 > words/part/KWDocument.cpp 432c65a > words/part/KWOdfWriter.cpp f9b4fe0 > words/part/author/CAuView.h 59a7df6 > words/part/author/CAuView.cpp 419e31a > words/part/author/CoverImage.h PRE-CREATION > words/part/author/CoverImage.cpp PRE-CREATION > words/part/author/author.rc 14c5e91 > > Diff: http://git.reviewboard.kde.org/r/107800/diff/ > > > Testing > ------- > > > Thanks, > > mojtaba shahi > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
