----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107100/#review26795 -----------------------------------------------------------
Has this been commited? It's has Ship it! but still shows as open in reviewboard. - Albert Astals Cid On Nov. 21, 2012, 10:49 p.m., Dimitrios Tanis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107100/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2012, 10:49 p.m.) > > > Review request for Calligra, Oleg Kukharchuk, Adam Pigg, and Jarosław Staniek. > > > Description > ------- > > When trying to create/open/import a project that requires a database server > driver, if none is found display a message informing about it and giving > general instructions what to do. > > > This addresses bug 131092. > http://bugs.kde.org/show_bug.cgi?id=131092 > > > Diffs > ----- > > kexi/kexiutils/utils.cpp 4f101e1 > kexi/main/startup/KexiNewProjectAssistant.h af89ef2 > kexi/main/startup/KexiNewProjectAssistant.cpp 75efbc1 > kexi/main/startup/KexiOpenProjectAssistant.h 595b0bb > kexi/main/startup/KexiOpenProjectAssistant.cpp 6af1e01 > kexi/widget/CMakeLists.txt 841794e > kexi/widget/KexiConnectionSelectorWidget.h 43bd7cc > kexi/widget/KexiConnectionSelectorWidget.cpp fd5c414 > kexi/widget/KexiServerDriverNotFoundMessage.h PRE-CREATION > kexi/widget/KexiServerDriverNotFoundMessage.cpp PRE-CREATION > kexi/kexiutils/utils.h 140ed7b > > Diff: http://git.reviewboard.kde.org/r/107100/diff/ > > > Testing > ------- > > Works when no db server driver present. IMHO though this solution is not > elegant at all as it is implemented in 3 different places. > > > Screenshots > ----------- > > > http://git.reviewboard.kde.org/r/107100/s/800/ > > http://git.reviewboard.kde.org/r/107100/s/801/ > > http://git.reviewboard.kde.org/r/107100/s/802/ > > http://git.reviewboard.kde.org/r/107100/s/839/ > > http://git.reviewboard.kde.org/r/107100/s/840/ > > http://git.reviewboard.kde.org/r/107100/s/841/ > > http://git.reviewboard.kde.org/r/107100/s/842/ > > http://git.reviewboard.kde.org/r/107100/s/843/ > > > Thanks, > > Dimitrios Tanis > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
