----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108586/#review26211 -----------------------------------------------------------
This review has been submitted with commit 1917836f0ed42af0520adcc87f81181c2f1f7ad9 by Friedrich W. H. Kossebau to branch master. - Commit Hook On Jan. 25, 2013, 11:10 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108586/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 11:10 p.m.) > > > Review request for Calligra and Marijn Kruisselbrink. > > > Description > ------- > > MSVC hinted that there is an endless loop waiting in this method. Right it > is! Somehow the method calls itself assuming that a signal exists with the > same name. > > Seems left-over from part->doc/part split. The related method in SheetAdaptor > is still commented out. > > Patch simply removes the method. Nothing is calling it at the moment anyway. > And it's about a property which does not belong to the document. > > > Diffs > ----- > > sheets/part/Doc.h e8f1f89 > sheets/part/Doc.cpp ca41249 > > Diff: http://git.reviewboard.kde.org/r/108586/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
