> On Jan. 20, 2013, 4:07 a.m., C. Boemann wrote: > > looks very good, except could you please move the command to > > kotext/commands instead
The reason it is there is because of translation requirement for 2.6. In kotext this will be a new string breaking string freeze. I'm ok with doing the move to kotext if you do not want this to go into 2.6 - Gopalakrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108491/#review25819 ----------------------------------------------------------- On Jan. 19, 2013, 4:40 p.m., Gopalakrishna Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108491/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2013, 4:40 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > ------- > > Implements Undo/Redo of paragraph settings as a command in the process fixing > bug 312318. > > > This addresses bug 312318. > http://bugs.kde.org/show_bug.cgi?id=312318 > > > Diffs > ----- > > libs/kotext/KoTextEditor.h 5c78240 > libs/kotext/KoTextEditor.cpp 414b5dc > libs/kotext/commands/ChangeListCommand.cpp d036d6e > plugins/textshape/CMakeLists.txt 1126de0 > plugins/textshape/commands/ParagraphSettingsCommand.h PRE-CREATION > plugins/textshape/commands/ParagraphSettingsCommand.cpp PRE-CREATION > plugins/textshape/dialogs/ParagraphSettingsDialog.cpp 4bd7a2c > > Diff: http://git.reviewboard.kde.org/r/108491/diff/ > > > Testing > ------- > > > Thanks, > > Gopalakrishna Bhat > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
