----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107475/#review25524 -----------------------------------------------------------
This review has been submitted with commit c2e399debeb87618ec249f0635e0188c68b203ab by Jaroslaw Staniek on behalf of Oleg Kukharchuk to branch calligra/2.4. - Commit Hook On Nov. 26, 2012, 1:45 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107475/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2012, 1:45 p.m.) > > > Review request for Calligra, Adam Pigg, Jarosław Staniek, and Dimitrios Tanis. > > > Description > ------- > > sqlite3_reset should be called immediately after sqlite3_step, because it > always return error when sqlite3_step return SQLITE_ERROR > > in existing implementation execute() will cause an error if previous > execute() failed. > > Details: http://www.sqlite.org/c3ref/reset.html > > Should be fixed in Predicate as well > > > Diffs > ----- > > libs/db/drivers/sqlite/sqlitepreparedstatement.h > be81bdc984be14eb67ff6d28d50936baeaa07173 > libs/db/drivers/sqlite/sqlitepreparedstatement.cpp > ffb751ebb1c87c32db95f48797e4c358c7b17991 > > Diff: http://git.reviewboard.kde.org/r/107475/diff/ > > > Testing > ------- > > tested on csv-import > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
