----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108353/#review25445 -----------------------------------------------------------
Ship it! The patch works for me to fix the bug as reported, so ship it, thanks. But... it opened the path to the next crash: selecting the char tab like in the bug reported, and then clicking the "New" button yields another crash, reported as https://bugs.kde.org/show_bug.cgi?id=313233 - Friedrich W. H. Kossebau On Jan. 11, 2013, 7:08 p.m., Pierre Stirnweiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108353/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2013, 7:08 p.m.) > > > Review request for Calligra, C. Boemann and Friedrich W. H. Kossebau. > > > Description > ------- > > On an empty style list, the style manager dialog would pass around null > styles (for preview,...). Add some test for null styles in some places solves > the crash. I will work on a new dialog in the very near future, so even if > the solution is not ideal (a big blank tab), it is the best we can do for 2.6. > > > This addresses bug 313031. > http://bugs.kde.org/show_bug.cgi?id=313031 > > > Diffs > ----- > > plugins/textshape/dialogs/FormattingPreview.cpp 1ed3b83 > plugins/textshape/dialogs/StyleManager.cpp c561d35 > > Diff: http://git.reviewboard.kde.org/r/108353/diff/ > > > Testing > ------- > > > Thanks, > > Pierre Stirnweiss > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
