----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108406/ -----------------------------------------------------------
Review request for Calligra, C. Boemann and Boudewijn Rempt. Description ------- KoTextWriter::Private::saveParagraph expects the QTextDocument object to have a KoTextRangeManager set. The sidewinder Excel import filter code did not know this. Attached patch fixes that by setting a dummy textrange manager during creation of the QTextDocument object that TxORecord uses. Okay to backport to 2.6? Ideally KoTextWriter would get a clean-up and just not assume certain properties. But with the current code it is better to just adapt all places that use KoTextWriter for now to always set at least a dummy textrange manager. Diffs ----- filters/sheets/excel/sidewinder/excel.cpp d665a42 Diff: http://git.reviewboard.kde.org/r/108406/diff/ Testing ------- A example xls file with a textframe object sent by philip is imported instead of crashing. Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
