----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108358/#review25311 -----------------------------------------------------------
With cstester I did not find and regressions but also no improvements. Maybe our test set of documents does not contain the feature set. >From looking at the code I also don't see anything that looks bad but I don't >know the code good enough to really comment on it. If you feel sure feel free >to commit. - Thorsten Zachmann On Jan. 12, 2013, 4:19 p.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108358/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2013, 4:19 p.m.) > > > Review request for Calligra and Thorsten Zachmann. > > > Description > ------- > > Shape moving restrictions based on anchor properties. > > This is the page anchors equivalent of the char and paragraph anchors > code we > already have. > > This makes a difference both on initial layout (nice improvements) > and on interactive moving of page anchored shapes. > > > Diffs > ----- > > libs/kotext/KoTextAnchor.cpp 6783bdc > plugins/defaultTools/defaulttool/ShapeMoveStrategy.h e2d26c2 > plugins/defaultTools/defaulttool/ShapeMoveStrategy.cpp 4ebfb57 > words/part/KWCanvasBase.cpp 5592e1d > words/part/KWRootAreaProvider.cpp a52c29e > words/part/frames/KWFrameLayout.h a7408b7 > words/part/frames/KWFrameLayout.cpp 4e389ff > > Diff: http://git.reviewboard.kde.org/r/108358/diff/ > > > Testing > ------- > > I have a simple test document created in LO that now loads correctly (was > very bad before) > > I've also played around with the interactive restrictions and they seem to > work as well. > > But a cstester run is needed > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
