> On Dec. 31, 2012, 2:09 p.m., Lukáš Tvrdý wrote: > > krita/ui/tool/kis_tool_freehand_helper.cpp, line 250 > > <http://git.reviewboard.kde.org/r/108049/diff/1/?file=103402#file103402line250> > > > > Please, don't remove the option where you can completely turn off > > smoothing. > > > > It can be useful for some brush engines that require raw mouse/tablet > > input and which do some kind of own smoothing or interpret the raw input > > somehow. E.g. experimental (Shape) brush engine in some settings is nice > > with non-smooth strokes. > > > > There might exists some smoothing also on driver level? And users might > > want to test that smoothing too, so let's give him this option.
Hm, well -- the issue is that we never actually give raw input. The old unsmoothed option paints a straight line between the positions we receive -- but doesn't really interpolate between those points. - Boudewijn ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108049/#review24333 ----------------------------------------------------------- On Dec. 31, 2012, 1:01 p.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108049/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2012, 1:01 p.m.) > > > Review request for Calligra, Cyrille Berger Skott, Dmitry Kazakov, Lukáš > Tvrdý, and Sven Langkamp. > > > Description > ------- > > This patch ports the smoothing algorithm from > http://www24.atwiki.jp/sigetch_2007/pages/17.html (as implemented in Gimp > 2.8) to Krita. The previous smoothing algorithm now is the unsmoothed > default, and the old completely unsmoothed option has gone. > > > This addresses bug 281267. > http://bugs.kde.org/show_bug.cgi?id=281267 > > > Diffs > ----- > > krita/image/brushengine/kis_paint_information.h 0142a33 > krita/image/kis_distance_information.h c1ab409 > krita/plugins/paintops/libpaintop/sensors/kis_dynamic_sensors.cc 16473f5 > krita/plugins/tools/defaulttools/kis_tool_brush.h f849233 > krita/plugins/tools/defaulttools/kis_tool_brush.cc 536b81d > krita/ui/tool/kis_tool_freehand.h ee915d8 > krita/ui/tool/kis_tool_freehand.cc 5640a4b > krita/ui/tool/kis_tool_freehand_helper.h 4978c85 > krita/ui/tool/kis_tool_freehand_helper.cpp dde51ea > > Diff: http://git.reviewboard.kde.org/r/108049/diff/ > > > Testing > ------- > > Animtim has tested the branch: > > 14:00:14 < Animtim_> boud: perfect > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
