----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108020/#review24225 -----------------------------------------------------------
This review has been submitted with commit 36a0bd51606da12659519021c219a778fd77034a by Pierre Stirnweiss to branch calligra/2.6. - Commit Hook On Dec. 30, 2012, 9:08 a.m., Pierre Stirnweiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108020/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2012, 9:08 a.m.) > > > Review request for Calligra and C. Boemann. > > > Description > ------- > > The style names containing a number were not sorted with natural order : > Content 1/Content 10/Content 2. > This is because QString::localeAwareCompare does not sort with natural order. > Use KSTringHandler::naturalCompare instead (it also uses > QString::localeAwareCompare internally). > > Ok to backport? > > > This addresses bug 288651. > http://bugs.kde.org/show_bug.cgi?id=288651 > > > Diffs > ----- > > plugins/textshape/dialogs/DockerStylesComboModel.cpp c1ffaa1 > plugins/textshape/dialogs/StylesModel.cpp 4b1b9f6 > > Diff: http://git.reviewboard.kde.org/r/108020/diff/ > > > Testing > ------- > > Styles are sorted in natural order now. I could not test regressions where > locale comparison would play a role however. But since KStringHandler's > comparison uses the Qt one, I don't expect a regression there. > > > Thanks, > > Pierre Stirnweiss > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
