----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107765/#review24158 -----------------------------------------------------------
Ship it! Only small issues. No need to rereview after the issues are fixed. filters/sheets/latex/export/latexexportdialog.h <http://git.reviewboard.kde.org/r/107765/#comment18481> The standard says to use m_ as prefix for members. filters/sheets/latex/export/latexexportdialog.h <http://git.reviewboard.kde.org/r/107765/#comment18482> _in is a strange name. I suggest m_store instead. filters/sheets/latex/export/latexexportdialog.cc <http://git.reviewboard.kde.org/r/107765/#comment18483> click filters/sheets/latex/export/latexexportdialog.cc <http://git.reviewboard.kde.org/r/107765/#comment18484> Nitpick, but shouldn't we use // as comment? Not sure it's in the standard though. filters/sheets/latex/export/latexexportdialog.cc <http://git.reviewboard.kde.org/r/107765/#comment18485> I think kdebugs should be disabled in the final commit. - Inge Wallin On Dec. 16, 2012, 6:30 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107765/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2012, 6:30 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Ported Dialog away from Q3ButtonGroup and K3ListBox. > Also made it a subclass of KDialog, instead of using a QDialog with custom > OK/Cancel buttons (and an unused Help button). > > > Diffs > ----- > > filters/sheets/CMakeLists.txt 9aae971 > filters/sheets/latex/export/CMakeLists.txt be9c94d > filters/sheets/latex/export/kspreadlatexexportdiaImpl.h 93852fd > filters/sheets/latex/export/kspreadlatexexportdiaImpl.cc 1370f14 > filters/sheets/latex/export/latexexport.cc 3ebd52d > filters/sheets/latex/export/latexexportAdaptor.h 5534d37 > filters/sheets/latex/export/latexexportAdaptor.cc 3cc3a62 > filters/sheets/latex/export/latexexportdia.ui 3f91f78 > filters/sheets/latex/export/latexexportdialog.h PRE-CREATION > filters/sheets/latex/export/latexexportdialog.cc PRE-CREATION > filters/sheets/latex/export/latexexportwidget.ui PRE-CREATION > sheets/CMakeLists.txt 399377c > > Diff: http://git.reviewboard.kde.org/r/107765/diff/ > > > Testing > ------- > > Created latex files had 0 diffs. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
