----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107890/ -----------------------------------------------------------
Review request for Calligra and Jarosław Staniek. Description ------- Follow-up to https://git.reviewboard.kde.org/r/107792/ No time/concentration yet found to do as suggested and follow the implementation of "KexiDateTableEdit/KexiTimeTableEdit/KexiDateTimeTableEdit (with Kexi*Formatter)". But this patch should at least improve the current situation, having the same format in display and edit mode, and also painting the upper border in edit mode. Switched from using KDE KLocale to QLocale for the display (as that is also what is used in the QDateTimeEdit). What should be used in an implementation done as suggested? Use as much kdelibs as possible, or should the KoProperty code trying to be more Qt-only? Patch also adds min & max options to DateTimeEdit. Diffs ----- libs/koproperty/editors/dateedit.h 356b236 libs/koproperty/editors/dateedit.cpp 3daa163 libs/koproperty/editors/datetimeedit.h bb04a9c libs/koproperty/editors/datetimeedit.cpp 09ca91e libs/koproperty/editors/timeedit.h 6b9861e libs/koproperty/editors/timeedit.cpp 9bc8e48 Diff: http://git.reviewboard.kde.org/r/107890/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
