----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107610/#review23181 -----------------------------------------------------------
kexi/migration/importwizard.h <http://git.reviewboard.kde.org/r/107610/#comment17729> I see Private has been removed from importwizard.h - mistake? Looks like the patch is invalid, e.g. there are no longer changes for KexiMigrate: https://git.reviewboard.kde.org/r/107610/diff/2/#index_header Please upload diff compared calligra master branch, not compared your recent local commit. - Jarosław Staniek On Dec. 8, 2012, 4:33 a.m., Shou Ya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107610/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2012, 4:33 a.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Description > ------- > > I've done with it for all the classes, please review. > > Good luck! > > > Diffs > ----- > > kexi/migration/importwizard.cpp c0f120f > kexi/migration/keximigrate.cpp 4e53d2d > kexi/plugins/importexport/csv/kexicsvwidgets.cpp 2c6f8c7 > kexi/plugins/reports/InternalSourceSelector.h cb8b0b4 > kexi/plugins/reports/kexidbreportdata.h deb4687 > kexi/plugins/reports/keximigratereportdata.h e4a88630 > kexi/plugins/reports/keximigratereportdata.cpp cf8abe8 > kexi/plugins/reports/kexisourceselector.h e44e15e > kexi/plugins/reports/kexisourceselector.cpp 808ae5b > kexi/widget/KexiNameWidget.cpp 021bc9f > kexi/widget/dataviewcommon/KexiTableViewColumn.cpp 14c2c35 > kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp b7c0043 > kexi/widget/dataviewcommon/kexidataawareview.cpp d608958 > kexi/widget/fields/KexiFieldListModelItem.cpp fe55b12 > kexi/widget/navigator/KexiProjectModelItem.h fe04381 > kexi/widget/navigator/KexiProjectModelItem.cpp 764c17a > kexi/widget/utils/kexidatetimeformatter.cpp fed7692 > > Diff: http://git.reviewboard.kde.org/r/107610/diff/ > > > Testing > ------- > > > Thanks, > > Shou Ya > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
