----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107506/#review22779 -----------------------------------------------------------
This review has been submitted with commit 302a8284a4c7915ef7ffc810bf8700360088885d by Friedrich W. H. Kossebau to branch calligra/2.6. - Commit Hook On Nov. 28, 2012, 6:18 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107506/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2012, 6:18 p.m.) > > > Review request for Calligra. > > > Description > ------- > > The old code in KoDocumentRdf::emitSemanticObjectUpdated(...) does not make > any sense to me, seems to be not cleaned-up code that just does not trigger a > bug, only abuses more cycles than needed: > > it loops over all xmlids of the item, just to call "insertReflow(col, item);" > each time. Now, KoDocumentRdf::insertReflow(...) itself does loop over all > xmlids and creates a reflowItem for each, then inserts that to the table/map. > Doing this the number of times of xmlids, like happening with the old code, > seems useless, as each time besides the first the existing entry in the col > map is just overwritten, as findExtent(xmlid) will always return the same for > the same xmlid. > > Okay to commit to 2.6 and master? > > > Diffs > ----- > > libs/main/rdf/KoDocumentRdf.cpp 00bc1bd > > Diff: http://git.reviewboard.kde.org/r/107506/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
