> On Nov. 28, 2012, 8:49 a.m., Inge Wallin wrote: > > The code looks good, I just had a couple of minor issues. What I wonder is > > if this is tested with LibreOffice and/or OpenOffice.org. Do we have > > interoperability? > > C. Boemann wrote: > I just tried and no there is no interperablity. Not sure it's such a > common use case to have both suites running simultaniously. Anyway they dont > seem to load/save to clipboard using odf. And our html exhange is not very > good it would seem > > As for your other comments. I've changed them but am not going to upload > a new diff just for that
They use HTML for cut&paste interchange? No, there is no need to upload a new diff. - Inge ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107495/#review22682 ----------------------------------------------------------- On Nov. 27, 2012, 8:43 p.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107495/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2012, 8:43 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch fixes copy/paste by > 1) saving the used styles to clipboard as well > 2) only add a style if another style named the same doesn't exist already > > > Diffs > ----- > > libs/kotext/KoTextDrag.cpp 9f2d537 > libs/kotext/KoTextOdfSaveHelper.h 39107ef > libs/kotext/KoTextOdfSaveHelper.cpp e01e651 > libs/kotext/opendocument/KoTextWriter.cpp 0d52062 > libs/kotext/opendocument/KoTextWriter_p.cpp 4439769 > libs/kotext/styles/KoStyleManager.h ae2e720 > libs/kotext/styles/KoStyleManager.cpp 2aa74fe > > Diff: http://git.reviewboard.kde.org/r/107495/diff/ > > > Testing > ------- > > Some basic cut and paste with variations of styles applied > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
