----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106756/ -----------------------------------------------------------
(Updated Oct. 20, 2012, 5:28 p.m.) Review request for Calligra. Changes ------- Updated the patch addressing the review comments. The changes from the earlier version of this patch are: 1) Remove the ability to play by clicking inside shape. Now it is an action in video tool. 2) Thumbnails for videoshape now works for gstreamer backend too. This is made possible by using the phononexperimental api's. I have been told on #kde-multimedia that the api's of the experimental stuff have not changed for the last one year or so. So I thought of using this to generate thumbnails. Any issues? PS: This patch has a couple of EOL spaces issues. I have fixed them locally here. Description ------- Add the following enhancements to videoshape 1) Enable videoshape in Words 2) Add playback controls to Video playback(Volume Control, Playback seeker) 3) Ability to save video within ODF documents. 4) Ability to change video of a video shape 5) Ability to play video in Words/Author by clicking on the play icon(inside the shape at the center). 6) Thumbnails for videoshape The thumbnail functionality is implemented but untested and hence #ifd out. The reason for this is that the Phonon::VideoWidget::snapshot() functionality is not implemented in the gstreamer backend(the one that I have). I have posted a related mail [1] to phonon-backends ml regarding this. [1] http://mail.kde.org/pipermail/phonon-backends/2012-October/000711.html Diffs (updated) ----- plugins/videoshape/CMakeLists.txt f4d81b6 plugins/videoshape/ChangeVideoCommand.h PRE-CREATION plugins/videoshape/ChangeVideoCommand.cpp PRE-CREATION plugins/videoshape/FullScreenPlayer.h aee2f90 plugins/videoshape/FullScreenPlayer.cpp a0faa5c plugins/videoshape/Plugin.cpp 39c38f0 plugins/videoshape/SelectVideoWidget.h PRE-CREATION plugins/videoshape/SelectVideoWidget.cpp PRE-CREATION plugins/videoshape/VideoCollection.h f5ece64 plugins/videoshape/VideoCollection.cpp 91c8a2d plugins/videoshape/VideoData.h 7bd7b7a plugins/videoshape/VideoData.cpp b5f4699 plugins/videoshape/VideoShape.h e9e65da plugins/videoshape/VideoShape.cpp 32744ab plugins/videoshape/VideoShapeConfigWidget.h 251dc75 plugins/videoshape/VideoShapeConfigWidget.cpp 4f5d22e plugins/videoshape/VideoThumbnailer.h PRE-CREATION plugins/videoshape/VideoThumbnailer.cpp PRE-CREATION plugins/videoshape/VideoTool.h PRE-CREATION plugins/videoshape/VideoTool.cpp PRE-CREATION plugins/videoshape/VideoToolFactory.h PRE-CREATION plugins/videoshape/VideoToolFactory.cpp PRE-CREATION plugins/videoshape/forms/VideoToolWidget.ui PRE-CREATION words/part/wordsrc 3b3c543 Diff: http://git.reviewboard.kde.org/r/106756/diff/ Testing ------- Thanks, Gopalakrishna Bhat
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
