----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106746/#review20018 -----------------------------------------------------------
Ship it! Looks nice, just fix the few issues below and push it :) (Don't forget to say REVIEW: <review-number> in your commit to close the review) active/qml/TextDocumentCenterOverlay.qml <http://git.reviewboard.kde.org/r/106746/#comment15859> Why is this needed? gotoPage() should set the currentIndex to the right value. active/qml/TextDocumentEditingToolbar.qml <http://git.reviewboard.kde.org/r/106746/#comment15860> This icon is for presentations, better to use some icon for text docs. The icon "page2-sides" seems nice. - Shantanu Tushar Jha On Oct. 6, 2012, 6:12 p.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106746/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2012, 6:12 p.m.) > > > Review request for Calligra and Shantanu Tushar Jha. > > > Description > ------- > > Create preview for the text documents > > > Diffs > ----- > > active/CMakeLists.txt 02e5918 > active/qml/TextDocumentCenterOverlay.qml PRE-CREATION > active/qml/TextDocumentEditingToolbar.qml 874bee7 > active/src/CATextDocumentHandler.h 303e45c > active/src/CATextDocumentHandler.cpp 49e02ca > active/src/CATextDocumentModel.h PRE-CREATION > active/src/CATextDocumentModel.cpp PRE-CREATION > active/src/MainWindow.cpp f095c54 > > Diff: http://git.reviewboard.kde.org/r/106746/diff/ > > > Testing > ------- > > Tested with the sample text doc and worked fine. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
