----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105703/#review19960 -----------------------------------------------------------
Ping? - Friedrich W. H. Kossebau On July 24, 2012, 4:09 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105703/ > ----------------------------------------------------------- > > (Updated July 24, 2012, 4:09 p.m.) > > > Review request for Calligra and Thorsten Zachmann. > > > Description > ------- > > The KPrView constructor adapts the actions for navigating in slides only for > the text, but not the tooltip and whatsthis property. > Visible by default in the slide navigator in the statusbar (no idea how I > missed that before, perhaps there was no tooltip set, so the text got > reused), but also if navigation actions are added to the toolbar. > > Backport to 2.5 would be setting tooltip and whatsthis to QString(), to avoid > new strings. > > I considered changing the KoPAView constructor to take an additional > parameter "KoPageApp::PageType pageType", so it can setup the proper text > strings itself, instead of relying on all the subclasses (well, just Stage > ATM) to adjust things. But that would be a too big change to backport. So > perhaps commit simple fix to 2.5 and moving action texts adaption to KoPAView > in master (would come up with a new patch)? > > > Diffs > ----- > > stage/part/KPrView.cpp 1606dfa > > Diff: http://git.reviewboard.kde.org/r/105703/diff/ > > > Testing > ------- > > Run Stage and Flow, no more bad tooltip in Stage. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
