----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106486/#review19099 -----------------------------------------------------------
filters/words/epub/OdtHtmlConverter.cpp <http://git.reviewboard.kde.org/r/106486/#comment15185> This can be simplified to m_imagesIndex.contains(imgSrc) which is much faster instead of getting all keys and then looking in there. filters/words/mobi/PalmDocCompression.cpp <http://git.reviewboard.kde.org/r/106486/#comment15186> The buffer needs to be delete after its usage. - Thorsten Zachmann On Sept. 17, 2012, 10:33 p.m., mojtaba shahi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106486/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2012, 10:33 p.m.) > > > Review request for Calligra. > > > Description > ------- > > After calligra Author announced, we had requests to add another filter export > to Mobi. > The Amazon kindles use this format for their ebooks. > MOBI is the format used by the MobiPocket Reader. It may have a .mobi > extension or it may have a .prc extension. The extension can be changed by > the user to either of the accepted forms. > It is a binary file that contains headers include PalmDoc headres and Mobi > headers then Text, that is a raw html file, and then images. For Text there > are three > modes: no compression, PalmDoc compression and HUFF/CDIC compression, that i > implement the palmDoc compression. For html i use OdtHtmlConverter but i need > something special for mobi so i handle my changes in class with a flag. > Somethings that are special for mobi is handle img tag that for mobi we dont > have any href it use another specific attribute named recindex, and for other > changes i didn't need meta or ling elements and there is other one for > internal links > that i haven't implementedit yet. > > you can get more information in > http://wiki.mobileread.com/wiki/MOBI#Description > > Tools that i use for This export are Calibre for read and compress the file, > MobiPacket creator the windows version (there is no linux version :) ) > That i tryed to follow the MobiPacket creator files structure. > > > Diffs > ----- > > filters/words/CMakeLists.txt 941b150 > filters/words/epub/OdfParser.cpp 4a6d670 > filters/words/epub/OdtHtmlConverter.h a3e9d33 > filters/words/epub/OdtHtmlConverter.cpp 9088546 > filters/words/epub/exportepub2.cpp a2daec8 > filters/words/epub/exporthtml.cpp a919a7a > filters/words/mobi/CMakeLists.txt PRE-CREATION > filters/words/mobi/MobiFile.h PRE-CREATION > filters/words/mobi/MobiFile.cpp PRE-CREATION > filters/words/mobi/MobiHeaderGenerator.h PRE-CREATION > filters/words/mobi/MobiHeaderGenerator.cpp PRE-CREATION > filters/words/mobi/PalmDocCompression.h PRE-CREATION > filters/words/mobi/PalmDocCompression.cpp PRE-CREATION > filters/words/mobi/exportmobi.h PRE-CREATION > filters/words/mobi/exportmobi.cpp PRE-CREATION > filters/words/mobi/words_Mobi_export.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106486/diff/ > > > Testing > ------- > > I tested some documents and it was good. > It is in its first step don't get hard test from it. :) > > > Thanks, > > mojtaba shahi > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
