----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106328/#review18526 -----------------------------------------------------------
Ship it! Ship It! - Adam Pigg On Sept. 4, 2012, 8:05 p.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106328/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2012, 8:05 p.m.) > > > Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk. > > > Description > ------- > > Table Designer: adding command to history should only redo() if needed > > Fixes commit ee6d9a744aa88af068470: "Ported the tables plugin to KUndo2 to > remove dependancy on Qt3Support". > > Details: > Table Designer is not written for undo/redo framework that always executes > redo() when pushing action on stack, so we needed option to avoid that. > Implementation internally adds a means to disable/enable redo(). > > > Diffs > ----- > > kexi/plugins/tables/kexitabledesignerview_p.cpp > d68e77b9d71c126f62eabbf215b916bc1968b4ae > kexi/plugins/tables/kexitabledesignerview_p.h > f74287cffa7d724727f2c6ffb17b24cdc8e9be70 > kexi/plugins/tables/kexitabledesignerview.cpp > cf6a212c6193e80c1ee08d59ef470b76ccaa5838 > kexi/plugins/tables/kexitabledesignerview.h > b43505c2bca34c4f6342cac61c072bec8ad60587 > kexi/plugins/tables/kexitabledesignercommands.cpp > b626beb036149518781266a2773a2d9b0f270a1a > kexi/plugins/tables/kexitabledesignercommands.h > 3a7994c88ac79fcc560b945a2708f935ab43e35f > > Diff: http://git.reviewboard.kde.org/r/106328/diff/ > > > Testing > ------- > > Tested for sample tables; improves editing > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
