> On Aug. 21, 2012, 7:14 p.m., Friedrich W. H. Kossebau wrote: > > libs/flake/KoHatchBackground.cpp, line 187 > > <http://git.reviewboard.kde.org/r/106115/diff/1/?file=79918#file79918line187> > > > > Misses to deal with any units deg, grad, rad, no?
I had a look at this and it seems that LO/OO does not support this here. Also the saving of the draw:rotation value seems to be incorrect as it is the angle * 10 which is not according to the spec. I had hoped that I can read it the way LO/OO does and then save it correctly but as they don't support the units I don't see how that can be done besides writing it out the way LO/OO does. Any ideas? > On Aug. 21, 2012, 7:14 p.m., Friedrich W. H. Kossebau wrote: > > libs/flake/KoHatchBackground.cpp, line 193 > > <http://git.reviewboard.kde.org/r/106115/diff/1/?file=79918#file79918line193> > > > > Any reason? Compatibility with LO/AOO? Just make sure there is a default in case it is not specified in the odf. LO/OO specifies it on saving so it is just a case to make sure we show something sensible when there is no data in the odf. - Thorsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106115/#review17814 ----------------------------------------------------------- On Aug. 21, 2012, 6:07 p.m., Thorsten Zachmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106115/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2012, 6:07 p.m.) > > > Review request for Calligra and Jan Hambrecht. > > > Description > ------- > > Implement correct support for hatch background as defined in odf. With this > patch the different styles, freely defined angles and distance between the > lines of the hatch is supported. > > This patch also changes the KoColorBackground to also use the d pointer of > the parent which reduces the memory needed for a KoColorBackground. > > > This addresses bugs 260534 and 298708. > http://bugs.kde.org/show_bug.cgi?id=260534 > http://bugs.kde.org/show_bug.cgi?id=298708 > > > Diffs > ----- > > libs/flake/CMakeLists.txt 15b6e6c > libs/flake/KoColorBackground.h 88b61bd > libs/flake/KoColorBackground.cpp 66d7ffc > libs/flake/KoColorBackground_p.h PRE-CREATION > libs/flake/KoHatchBackground.h PRE-CREATION > libs/flake/KoHatchBackground.cpp PRE-CREATION > libs/flake/KoShape.cpp 3a32e9f > > Diff: http://git.reviewboard.kde.org/r/106115/diff/ > > > Testing > ------- > > Tested with cstester and the documents of the bug reports. > > > Thanks, > > Thorsten Zachmann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
