----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106154/#review17975 -----------------------------------------------------------
This review has been submitted with commit e9d66bbf48318312da4973271b5455c6b26b43b9 by Thorsten Zachmann to branch master. - Commit Hook On Aug. 24, 2012, 4:35 a.m., Thorsten Zachmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106154/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2012, 4:35 a.m.) > > > Review request for Calligra. > > > Description > ------- > > When testing I found some memory leaks: > > ==31293== 1,708 (136 direct, 1,572 indirect) bytes in 1 blocks are definitely > lost in loss record 2,039 of 2,111 > ==31293== at 0x4C2B1C7: operator new(unsigned long) (in > /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) > ==31293== by 0x6B512A1: QObject::QObject(QObject*) (qobject.cpp:721) > ==31293== by 0x8767D6D: KoCharacterStyle::KoCharacterStyle(QObject*) > (KoCharacterStyle.cpp:343) > ==31293== by 0x8773CDF: KoParagraphStyle::KoParagraphStyle(QObject*) > (KoParagraphStyle.cpp:97) > ==31293== by 0x7F6E40C: KoTextShapeData::loadStyle(KoXmlElement const&, > KoShapeLoadingContext&) (KoTextShapeData.cpp:331) > ==31293== by 0x8B8EDDD: KoTosContainer::loadText(KoXmlElement const&, > KoShapeLoadingContext&) (KoTosContainer.cpp:88) > ==31293== by 0x22E762B6: EnhancedPathShape::loadOdf(KoXmlElement const&, > KoShapeLoadingContext&) (EnhancedPathShape.cpp:585) > ==31293== by 0x8B3C5D0: > KoShapeFactoryBase::createShapeFromOdf(KoXmlElement const&, > KoShapeLoadingContext&) (KoShapeFactoryBase.cpp:228) > ==31293== by 0x8B38735: > KoShapeRegistry::Private::createShapeInternal(KoXmlElement const&, > KoShapeLoadingContext&, KoXmlElement const&) const (KoShapeRegistry.cpp:313) > ==31293== by 0x8B382BB: KoShapeRegistry::createShapeFromOdf(KoXmlElement > const&, KoShapeLoadingContext&) const (KoShapeRegistry.cpp:268) > ==31293== by 0x1D047D12: KoPAPageBase::loadOdf(KoXmlElement const&, > KoShapeLoadingContext&) (KoPAPageBase.cpp:212) > ==31293== by 0x1CD5DBEA: KPrPage::loadOdf(KoXmlElement const&, > KoShapeLoadingContext&) (KPrPage.cpp:126) > > here the default style is not freed as the paragraph styles. > > From the other I don't have the log as it was from a different run. However > as we create the d_ptr we should also delete the d_ptr and not d. > > > Diffs > ----- > > libs/flake/tools/KoInteractionStrategy.cpp 82f286f > libs/textlayout/KoTextShapeData.cpp 7ac7f92 > > Diff: http://git.reviewboard.kde.org/r/106154/diff/ > > > Testing > ------- > > > Thanks, > > Thorsten Zachmann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
