> On Aug. 23, 2012, 6 p.m., Adam Pigg wrote: > > kexi/core/kexiproject.cpp, line 1248 > > <http://git.reviewboard.kde.org/r/106132/diff/1/?file=80134#file80134line1248> > > > > Im thinking of using this for storage of database wide, global > > settings, ie, something not associated with a particulat object. perhaps > > objectid 0 could be a special case for this?
Global settings using this facility is good idea. It will be separate task together with a small GUI for at least minimal set of settings. SO I propose not to extend purpose of this patch. Regarding meaning of 0: I propose to stay with relationships, so global area will have just another ID (just like any other plugin type), assigned dynamically. This way we would get backward compatibility and consistency (relationships for every record of the kexi__userdata table). So I am dropping this issue in this very review if you do not mind. - Jarosław ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106132/#review17912 ----------------------------------------------------------- On Aug. 23, 2012, 12:08 a.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106132/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2012, 12:08 a.m.) > > > Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk. > > > Description > ------- > > Add support for user data storage and remember column widths in table > > Core > *Add support for user data storage > BUG:305074 > > Table View > *Remember column widths in tabular data view > BUG:230994 > > > KexiDB > *Added helpers needed for saving string lists and removing data > > > This addresses bugs 230994 and 305074. > http://bugs.kde.org/show_bug.cgi?id=230994 > http://bugs.kde.org/show_bug.cgi?id=305074 > > > Diffs > ----- > > kexi/core/KexiView.h 283236c > kexi/core/KexiView.cpp 06763d9 > kexi/core/KexiWindow.h ce67eff > kexi/core/KexiWindow.cpp 16c1daf > kexi/core/kexiproject.h 855291a > kexi/core/kexiproject.cpp 189bbf2 > kexi/main/KexiMainWindow_p.h 9c24236 > kexi/plugins/scripting/kexidb/kexidbfield.h ce5fc5b > kexi/plugins/scripting/kexidb/kexidbfield.cpp 9829bac > kexi/plugins/tables/kexitabledesignerview.cpp 245eaa1 > kexi/widget/dataviewcommon/KexiTableViewColumn.h cc8326e > kexi/widget/dataviewcommon/KexiTableViewColumn.cpp 90ea429 > kexi/widget/dataviewcommon/kexidataawareobjectiface.cpp 22345a5 > kexi/widget/dataviewcommon/kexidataawareview.cpp 1128bd4 > kexi/widget/dataviewcommon/kexitableviewdata.h b3f9aac > kexi/widget/tableview/kexidatatable.h 6cb8854 > kexi/widget/tableview/kexidatatable.cpp ad60d6b > kexi/widget/tableview/kexidatatableview.h 0ddcc1e > kexi/widget/tableview/kexidatatableview.cpp 775c33d > libs/db/field.h 7ae2653 > libs/db/field.cpp 0dff112 > libs/db/utils.h 007c043 > libs/db/utils.cpp 05af25a > > Diff: http://git.reviewboard.kde.org/r/106132/diff/ > > > Testing > ------- > > Tested on data table view > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
