> On Aug. 19, 2012, 1:50 p.m., José Luis Vergara wrote: > > I just turned this patch into a branch called > > author-testpatch-pentalis > > So others can test. I will review in a moment, after I finish testing.
I tested: The branch compiled correctly -- check calligraauthor and calligrawords stored their settings separately -- check Bugs I found in Author were present in Words too (with the exception of the known issue mentioned in the review request), so those are not new bugs -- check I checked the 3 files modified for Words, and if they had introduced a new bug I should've noticed it the moment I run both applications in parallel, something involving the document view, I saw nothing wrong, so I think this branch doesn't introduce any new issue. I say Ship It, remember to squash it so the whole creation of Author is seen as a single commit. - José Luis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106064/#review17710 ----------------------------------------------------------- On Aug. 19, 2012, 6:20 a.m., Gopalakrishna Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106064/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2012, 6:20 a.m.) > > > Review request for Calligra. > > > Description > ------- > > This is the first step in realizing [1]. Currently author resides in > words/part and will eventually moved out to a directory of its own. This > patch is currently a work in progress and to evaluate that we are on the > right path. > > Currently there is a known issue that various options of the text tool are > not shown for the first time when the application is launched(see attached > snapshot). Once I explicitly activate the tool by switching to a different > tool and back it works fine. Any ideas what can be wrong? > > > [1] http://www.calligra.org/news/calligra-announces-author/ > > > Diffs > ----- > > words/part/CMakeLists.txt cdeca2b > words/part/KWPart.h 5b6621b > words/part/KWPart.cpp f94354a > words/part/author/CAuAboutData.h PRE-CREATION > words/part/author/CAuFactory.h PRE-CREATION > words/part/author/CAuFactory.cpp PRE-CREATION > words/part/author/CAuFactoryInit.cpp PRE-CREATION > words/part/author/CAuPart.h PRE-CREATION > words/part/author/CAuPart.cpp PRE-CREATION > words/part/author/CAuView.h PRE-CREATION > words/part/author/CAuView.cpp PRE-CREATION > words/part/author/author.desktop PRE-CREATION > words/part/author/author.rc PRE-CREATION > words/part/author/author_readonly.rc PRE-CREATION > words/part/author/authorpart.desktop PRE-CREATION > words/part/author/authorrc PRE-CREATION > words/part/author/main.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106064/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > Text Tool > http://git.reviewboard.kde.org/r/106064/s/678/ > > > Thanks, > > Gopalakrishna Bhat > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
