----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105896/ -----------------------------------------------------------
Review request for Calligra. Description ------- When investigating the reason for crash for bug 304674 I found out that a very a bug had sneeked in during some refactor of the KoDocumentResourceProvider and KoCanvasResourceProvider. The problem there was that the canvas resource current page had changed and that triggered a repaint which resulted in a crash (Crash fixed by a better fix). However the reason there was a repaint was that the signal for changing the current page resource triggered in KoPathTool::resourceChanged the trigger for HandleRadius as both resource providers did trigger the same slot with oververlapping resources :-(. Seems like this was not the only place where this was done. I have fixed that by adding a second slot for the documentResourceChanged and now the different slots are used for the different resources to no longer mix stuff there. I tried my best to find all occurrences of the problem. Ok to backport to 2.5? Diffs ----- karbon/plugins/tools/KarbonGradientTool.h 40d3645 karbon/plugins/tools/KarbonGradientTool.cpp 0e7479a karbon/plugins/tools/KarbonPatternTool.h 093932b karbon/plugins/tools/KarbonPatternTool.cpp 5a783be libs/flake/KoToolBase.h 2d203b6 libs/flake/KoToolBase.cpp f0f1ad1 libs/flake/KoToolBase_p.h 95d5bd7 libs/flake/tools/KoCreatePathTool.h 442e5ce libs/flake/tools/KoCreatePathTool.cpp 6651a3a libs/flake/tools/KoPathTool.h abb4e1a libs/flake/tools/KoPathTool.cpp 6fb89df Diff: http://git.reviewboard.kde.org/r/105896/diff/ Testing ------- Before the crash fix this change made sure the crash is gone as the code no longer triggered the wrong resource change. Thanks, Thorsten Zachmann
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
