> On July 28, 2012, 7:40 a.m., Jarosław Staniek wrote: > > kexi/plugins/forms/widgets/kexidbprogressbar.h, line 41 > > <http://git.reviewboard.kde.org/r/105741/diff/1/?file=74904#file74904line41> > > > > +explicit
fixed > On July 28, 2012, 7:40 a.m., Jarosław Staniek wrote: > > kexi/plugins/forms/widgets/kexidbslider.h, line 41 > > <http://git.reviewboard.kde.org/r/105741/diff/1/?file=74906#file74906line41> > > > > +explicit fixed > On July 28, 2012, 7:40 a.m., Jarosław Staniek wrote: > > kexi/widget/kexislider.h, line 51 > > <http://git.reviewboard.kde.org/r/105741/diff/1/?file=74909#file74909line51> > > > > +explicit fixed > On July 28, 2012, 7:40 a.m., Jarosław Staniek wrote: > > kexi/widget/kexislider.h, line 89 > > <http://git.reviewboard.kde.org/r/105741/diff/1/?file=74909#file74909line89> > > > > Is this class needed in public header? Maybe it could go to > > kexislider_p.h? moved to kexislider.cpp - Oleg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105741/#review16563 ----------------------------------------------------------- On July 26, 2012, 6:45 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105741/ > ----------------------------------------------------------- > > (Updated July 26, 2012, 6:45 p.m.) > > > Review request for Calligra, Jarosław Staniek and Adam Pigg. > > > Description > ------- > > * added KexiSlider widget > * KexiDBSlider uses KexiSlider now > * added i18n for new widgets > * fixes for KexiDBCommandLinkButton > > > Diffs > ----- > > kexi/formeditor/form.cpp b2b0c01328d4c5a0ad42c1297ac0c8aefd05494e > kexi/kexiutils/KexiCommandLinkButton.cpp > 6c63bf33bf1456c6f9bcc4417df462a97dc2a559 > kexi/plugins/forms/CMakeLists.txt 50fa9bf02957f45f38ed5ec48bbc2709f618190b > kexi/plugins/forms/kexidbfactory.cpp > 233923050f6499f4577f18323002bdccf6173922 > kexi/plugins/forms/widgets/kexidbprogressbar.h > 0617508f95cb07420e9f35b6357dbf8e127750a5 > kexi/plugins/forms/widgets/kexidbprogressbar.cpp > 28cf7c1408f14424df02b2e7e5e772502dcd1140 > kexi/plugins/forms/widgets/kexidbslider.h > 5889d0b2fc2e4f5ecdf81f41ad726d83bcc69d6d > kexi/plugins/forms/widgets/kexidbslider.cpp > a8300c28ee2e7212b49c626237ee119dcdca2d6d > kexi/widget/CMakeLists.txt b1149c8be04c7ceb08e6a9dd534bcbefa35db0d3 > kexi/widget/kexislider.h PRE-CREATION > kexi/widget/kexislider.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105741/diff/ > > > Testing > ------- > > tested on current master branch > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
