----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105650/#review16191 -----------------------------------------------------------
Ship it! Looks good. Good work. Please commit. Should we ask an aartist to come up with the icons? If you continue to work on it I thing that widget is a bit to wide for my taste. Not sure why that is. - Thorsten Zachmann On July 21, 2012, 11:35 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105650/ > ----------------------------------------------------------- > > (Updated July 21, 2012, 11:35 p.m.) > > > Review request for Calligra. > > > Description > ------- > > The dialog for the guides tool looked a little confusing to me (besides the > three icons missing): > * the erase-previous-guides checkbox was lined with the put-guides-at-x-edge > checkboxes > * the put-guides-at-x-edge checkboxes were not lined with the > number-of-guides inputs > * to add guides, first the checkbox for the orientation has to be clicked to > enable, then only the number-of-guides input > * order is vertical, then horizontal, while in other places it is horizontal, > then vertical > > Attached patch fixes all that, by > * using order horizontal, then vertical > * removing the checkboxes for the orientation and using None value for no > guides > * moving the put-guides-at-x-edge checkboxes behind the respective > number-of-guides input > * turning the icon-only erase-previous-guides checkbox into a text-only one, > for more expliteness (and removing need for icon) > > Not yet perfect, but a little better than before IMHO. > > > Diffs > ----- > > plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.h 7fad354 > plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.cpp 21ab34b > plugins/defaultTools/guidestool/InsertGuidesToolOptionWidget.ui 91059d1 > > Diff: http://git.reviewboard.kde.org/r/105650/diff/ > > > Testing > ------- > > > Screenshots > ----------- > > Before > http://git.reviewboard.kde.org/r/105650/s/640/ > After > http://git.reviewboard.kde.org/r/105650/s/641/ > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
