----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105606/#review16072 -----------------------------------------------------------
Ship it! Run cstester and no regressions found. Nice work. - Thorsten Zachmann On July 18, 2012, 2:10 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105606/ > ----------------------------------------------------------- > > (Updated July 18, 2012, 2:10 a.m.) > > > Review request for Calligra. > > > Description > ------- > > KoShadowStyle has small issues on loading and saving. This makes > "TestOpenDocumentStyle testParagraphStyle" fail on the attribute > "style:shadow". > > Attached patch fixes that: > * also allow color at end > * do not write invalid color > > With this patch and the "fix parsing of fo:border in KoParagraphStyle" one > "TestOpenDocumentStyle testParagraphStyle" no longer fails on anything for me. > > Okay to backport to 2.5? > > > Diffs > ----- > > libs/kotext/styles/tests/TestOpenDocumentStyle.cpp d0aadd4 > libs/odf/KoShadowStyle.cpp c12ee92 > > Diff: http://git.reviewboard.kde.org/r/105606/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
