----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105604/#review16056 -----------------------------------------------------------
Ship it! Please fix the noted stuff and then please commit. Run cstester and no regressions found. Nice work. libs/kotext/styles/KoParagraphStyle.cpp <http://git.reviewboard.kde.org/r/105604/#comment12635> The copying of the data should be moved after the test as only then it is needed. This should speed it up in case the parsing fails. libs/kotext/styles/KoParagraphStyle.cpp <http://git.reviewboard.kde.org/r/105604/#comment12634> There should be a blank before and after &. Please fix that in all occuring places. - Thorsten Zachmann On July 18, 2012, 2:05 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105604/ > ----------------------------------------------------------- > > (Updated July 18, 2012, 2:05 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Current parsing code for fo:border in KoParagraphStyle was not taking into > account all the possible data variation in the value string to parse. > > Attached fixes that. As a result "TestOpenDocumentStyle testParagraphStyle" > does no longer fail on the attribute fo:border (only on style:shadow, fix > coming as separate review request). > > Also changes a bad test value (0cm, while only positive integer are allowed > here). > > Okay to backport to 2.5? > > > Diffs > ----- > > libs/kotext/styles/KoParagraphStyle.cpp 820da77 > libs/kotext/styles/tests/TestOpenDocumentStyle.cpp d0aadd4 > > Diff: http://git.reviewboard.kde.org/r/105604/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
