----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105425/ -----------------------------------------------------------
Review request for Calligra. Description ------- None of the Calligra parts uses Part::setWidget(...) or reimplements Part::widget(). So all KPart supporting programs like Konqueror will crash when they try to get the widget from the part (and expect to get one). Just try yourself and do a Preview with... for some Calligra supported file. Attached patch fixes that by simply removing the claim that CalligraParts are real KParts/ReadOnlyPart,KParts/ReadWritePart. By-effect is that sadly support for loading in Konqueror or KDevelop is gone, but well, effectively it already is. Hopefully the Parts->Doc/View refactoring from Boudewijn/Boemann can get us that back in the future? Did not check, but guess this patch needs backporting to 2.5 as well. Diffs ----- flow/part/flowpart.desktop fb17a3b karbon/data/karbonpart.desktop c5e0b0b krita/kritapart.desktop 00fe3bf libs/main/KoTemplate.cpp e74aaa4 plan/planpart.desktop dfd3d0f plugins/chartshape/kchartpart.desktop 027f628 plugins/formulashape/kformulapart.desktop 1a91584 servicetypes/calligrapart.desktop ee551d8 sheets/sheetspart.desktop 5264778 stage/part/stagepart.desktop e1f5ce6 words/part/wordspart.desktop f0ca727 Diff: http://git.reviewboard.kde.org/r/105425/diff/ Testing ------- Tried to preview files with Konqueror & to load them with Calligra programs. Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
