Hi Timothée,
Am Sonntag, 1. Juli 2012, 12:25:38 schrieb Timothée Giet:
> Git commit 08e1c0a139f19e2bbbd620dbbcaafcf9e991d9c0 by Timothée Giet.
> Committed on 01/07/2012 at 11:59.
> Pushed by timotheegiet into branch 'master'.
>
> Add design templates from deevad
>
> Some common useful basic templates.
There is a small issue with this commit:
all the .desktop files reference their preview images to be in the relative
directory .icon/, but the CMakeLists.txt installs the images to the the icon
dirs of Krita,
As result they will not be found and the "Unknown" icon is displayed for all
the "Design templates".
Attached patch fixes that. Okay to commit?
But there is still an issue with the icons. They must stored in a square size
(with transparent parts), otherwise the KIconLoader adds black borders on
making it square. And ideally they are in 128x128 size, as that is the max
size used on the detail preview. That way no ugly upscaling happens.
(I currently investigate if there is a way to make KIconLoader use ARGB when
loading the image, so it does not add black borders. Hopefully there is some
PNG format flag which enforces ARGB)
Cheers
Friedrich
diff --git a/krita/data/templates/design/CMakeLists.txt b/krita/data/templates/design/CMakeLists.txt
index d16b35f..05eeb4b 100644
--- a/krita/data/templates/design/CMakeLists.txt
+++ b/krita/data/templates/design/CMakeLists.txt
@@ -1,5 +1,12 @@
-kde4_install_icons(${DATA_INSTALL_DIR}/krita/icons )
-install( FILES
+install( FILES
+ Designcinema2.39:1[2484x1040,96dpiRGB,8bit].png
+ Designcinema16:10[2484x1200,96dpiRGB,8bit].png
+ DesignpresentationA3Landscape[4960x3508,300dpiRGB,8bit].png
+ DesignpresentationA4portrait[2480x3508,300dpiRGB,8bit].png
+ Designscreen4:3[2250x1680,96dpiRGB,8bit].png
+DESTINATION ${DATA_INSTALL_DIR}/krita/templates/design/.icon)
+
+install( FILES
Designcinema2.39:1[2484x1040,96dpiRGB,8bit].kra
Designcinema16:10[2484x1200,96dpiRGB,8bit].kra
DesignpresentationA3Landscape[4960x3508,300dpiRGB,8bit].kra
@@ -7,7 +14,7 @@ install( FILES
Designscreen4:3[2250x1680,96dpiRGB,8bit].kra
DESTINATION ${DATA_INSTALL_DIR}/krita/templates/design/.source)
-install( FILES
+install( FILES
.directory
Designcinema2.39:1[2484x1040,96dpiRGB,8bit].desktop
Designcinema16:10[2484x1200,96dpiRGB,8bit].desktop
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
