-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105284/
-----------------------------------------------------------
(Updated June 17, 2012, 8:54 p.m.)
Review request for Calligra.
Changes
-------
Also giving detailed change comments.
Description (updated)
-------
Fixes all those icon names referencing to non-existing icons for which there is
a proper icon in Oxygen 4.3.5 or coming with Calligra itself (IMHO :))
Also renames ox22-action-arrow-right-calligra.png to
hi22-action-arrow-right.png,
because it is no oxygen one, and after change aligned with other arrow icons.
Okay to also commit to master as well?
Dealt entries from the report of the koIcon script, commented how I propose to
solve it:
arrow-down-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:298
arrow-up-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:265
arrow-left-calligra
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp:232
There is hi-version without -calligra prefix
Also renamed ox22-action-arrow-right-calligra.png to
hi22-action-arrow-right.png,
because it is no oxygen one, and after change aligned with other arrow icons.
star
plugins/pathshapes/star/StarShapeFactory.cpp:40
14_layer_novisible
libs/kopageapp/KoPADocumentModel.cpp:314
14_layer_visible
libs/kopageapp/KoPADocumentModel.cpp:314
Oxygen from 4.3.5 has layer-visible-on and layer-visible-off icons, so use them.
fontsizeup
sheets/ui/CellToolBase.cpp:415
fontsizedown
sheets/ui/CellToolBase.cpp:421
There is also no icon in Kate/KWrite for that, so for now just use no icon
text
plugins/artistictextshape/ArtisticTextShapeFactory.cpp:33
Solved by reusing x-shape-text
open
plugins/pictureshape/PictureTool.cpp:110
plugins/staging/templateshape/TemplateTool.cpp:90
plugins/vectorshape/VectorTool.cpp:75
Solved by changing to document-open
Diffs
-----
libs/kopageapp/KoPADocumentModel.cpp 69feb88
plugins/artistictextshape/ArtisticTextShapeFactory.cpp 2438b20
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp d820c43
plugins/pathshapes/pics/hi22-action-arrow-right.png PRE-CREATION
plugins/pathshapes/pics/ox22-action-arrow-right-calligra.png dbb9e5a
plugins/pathshapes/star/StarShapeFactory.cpp e6a9c6d
plugins/pictureshape/PictureTool.cpp bf15751
plugins/staging/templateshape/TemplateTool.cpp 6373aa2
plugins/vectorshape/VectorTool.cpp 79742fd
sheets/ui/CellToolBase.cpp 89b79f9
Diff: http://git.reviewboard.kde.org/r/105284/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
