----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105213/#review14626 -----------------------------------------------------------
I've tried your branch :) I'm wondering why both a timeline and the move up and down buttons. It seems to me that you now have two competing ways of representing time info. -The horizontal expressed in seconds. And by definition we cannot express what happens in a timeline, because what happens changes with user interaction. -The vertical that express interactive order and is controled by the move up and down buttons. Also the first two colums are rather pointless. I assume they are just visible for debugging purposes? Other than that the code looks reasonably fine to me. stage/part/KPrAnimationsDataModel.cpp <http://git.reviewboard.kde.org/r/105213/#comment11551> spaces stage/part/KPrAnimationsDataModel.cpp <http://git.reviewboard.kde.org/r/105213/#comment11552> what is wrong with KIcon("onclick") same goes every other place you load an icon stage/part/KPrAnimationsDataModel.cpp <http://git.reviewboard.kde.org/r/105213/#comment11553> spaces on both sides of / please - C. Boemann On June 11, 2012, 6:40 a.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105213/ > ----------------------------------------------------------- > > (Updated June 11, 2012, 6:40 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Add a docker to the Animation Tool to display information of shape > animations. The docker has the following features: > - use a compound view with a time line for start, duration and animation type > information. > - Has a button to play shape animations live preview. > - Layout edition buttons (edition features are not yet implemented) > > Add a model to manage animations data information > Extend shapeAnimation class in order to save presentation-preset tags with > information of animation type (entrance, exit, etc) and name. > > The patch is only for a GSoC progress Review. Though being usable (and I hope > stable), not yet finished. > > > Diffs > ----- > > stage/part/CMakeLists.txt 8617020a5e54ca640ef713257b94b4a8c9acf5fd > stage/part/KPrAnimationsDataModel.h PRE-CREATION > stage/part/KPrAnimationsDataModel.cpp PRE-CREATION > stage/part/KPrAnimationsTimeLineView.h PRE-CREATION > stage/part/KPrAnimationsTimeLineView.cpp PRE-CREATION > stage/part/KPrTimeLineHeader.h PRE-CREATION > stage/part/KPrTimeLineHeader.cpp PRE-CREATION > stage/part/KPrTimeLineView.h PRE-CREATION > stage/part/KPrTimeLineView.cpp PRE-CREATION > stage/part/KPrViewModePreviewShapeAnimations.h PRE-CREATION > stage/part/KPrViewModePreviewShapeAnimations.cpp PRE-CREATION > stage/part/animations/KPrAnimationBase.h > b12bfab8d71a9a9a6dc0695d2ed95bc2e7326352 > stage/part/animations/KPrAnimationBase.cpp > 62bb2a2911c37962ab55a38ed0b753f7b390ce31 > stage/part/animations/KPrAnimationLoader.cpp > b0680b401c86f743c15f4b9e6edea9c0de938eee > stage/part/animations/KPrAnimationStep.h > 26a9fcec4b1d894ffe4d7d1dd2458a34c35e3d64 > stage/part/animations/KPrShapeAnimation.h > f5d9ac3b796e75f16970f80245e1fbb6673fe1b9 > stage/part/animations/KPrShapeAnimation.cpp > 988cd14098d8ac1f9290b858540215d75d97f9f3 > stage/part/tools/animationtool/CMakeLists.txt > 5f5cb93f681ab95b0294de540e681d44ea9d27cb > stage/part/tools/animationtool/KPrAnimationTool.h > dbf12b9226f4da7b975d49ee19e5c7568cef7367 > stage/part/tools/animationtool/KPrAnimationTool.cpp > 99f3d5428f9a761d5376af6a5c1cf9a512266347 > stage/part/tools/animationtool/KPrShapeAnimationDocker.h PRE-CREATION > stage/part/tools/animationtool/KPrShapeAnimationDocker.cpp PRE-CREATION > stage/pics/hi32-action-after_previous.png PRE-CREATION > stage/pics/hi32-action-edit_animation.png PRE-CREATION > stage/pics/hi32-action-onclick.png PRE-CREATION > stage/pics/hi32-action-unrecognized_animation.png PRE-CREATION > stage/pics/hi32-action-with_previous.png PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105213/diff/ > > > Testing > ------- > > > Thanks, > > Paul Mendez > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
