----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103538/#review14509 -----------------------------------------------------------
One think I noted is that when you select a slide by pressing plus or if you deselect a slide by pressing minus the icon does not change to minus/plus and you first need to leave and enter the slide again before you can change the selection. stage/part/KPrViewModeSlidesSorter.cpp <http://git.reviewboard.kde.org/r/103538/#comment11472> Please move into the if block. Also move the slides into the if block. stage/part/KPrViewModeSlidesSorter.cpp <http://git.reviewboard.kde.org/r/103538/#comment11471> Please move into the if block as it is only usefull if there was a page. Also the QList init can be moved to the if block stage/part/KPrViewModeSlidesSorter.cpp <http://git.reviewboard.kde.org/r/103538/#comment11470> Starting a presentation does not work for me. Not sure what is wrong but I only get an empty white page when I start the presentation. Starting a presentation from the normal view works without a problem - Thorsten Zachmann On June 8, 2012, 6:03 a.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103538/ > ----------------------------------------------------------- > > (Updated June 8, 2012, 6:03 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Stage slides sorter has +/- buttons that appear when you move the mouse over > an item to allow you select > or deselect multiple items without using the keyboard. This patch add extra > actions (remove/duplicate slide and start slideshow from here) > like gwenview, digikam quick actions. > > > Diffs > ----- > > libs/kopageapp/KoPADocumentStructureDocker.h > c49c429c6c0b8a11f0c024bce1accc2a7203fcff > libs/kopageapp/KoPADocumentStructureDocker.cpp > 7b31e5423db47955df6af9e2bb8ba3897895c61f > libs/widgets/CMakeLists.txt 9c25397ca1c475a90b94f5c188fb0cdaf3f39373 > libs/widgets/KoContextBarButton.h PRE-CREATION > libs/widgets/KoContextBarButton.cpp PRE-CREATION > libs/widgets/KoSelectionManager.h a2db231db64982b836e67f3d3d40dca468aa0d6d > libs/widgets/KoSelectionManager.cpp > 23d0d88f951d701b82b43970a0f9d58043f96b52 > libs/widgets/KoSelectionToggle.h e83409fcded1cb2a7ef9fe0919a06308903aa9c0 > libs/widgets/KoSelectionToggle.cpp 6ad6866c857761aa2d2b0becd42db7e980e1e996 > libs/widgets/KoViewItemContextBar.h PRE-CREATION > libs/widgets/KoViewItemContextBar.cpp PRE-CREATION > stage/part/KPrSlidesSorterDocumentModel.cpp > 74e7e7b98cec9cef720a81a030604ad7e98859bf > stage/part/KPrViewModeSlidesSorter.h > 705fd2a9cd6286ba12fe6836f622bf4ceda51367 > stage/part/KPrViewModeSlidesSorter.cpp > 16d0bc051aed66a181b9f8479eca203fc14a6174 > > Diff: http://git.reviewboard.kde.org/r/103538/diff/ > > > Testing > ------- > > build and run > > > Thanks, > > Paul Mendez > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
